chore(exporter-logs-otlp-proto): rename OTLPLogsExporter to OTLPLogEx… #4140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porter for consistency Fixes open-telemetry#4139
dyladan
approved these changes
Sep 12, 2023
|
Unfortunate that the name will conflict with the package name itself but changing the package name is probably too big of a break even for an experimental package for such a small benefit |
pichlermarc
approved these changes
Sep 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #4140 +/- ##
==========================================
- Coverage 92.24% 91.18% -1.06%
==========================================
Files 326 237 -89
Lines 9299 6424 -2875
Branches 1971 1385 -586
==========================================
- Hits 8578 5858 -2720
+ Misses 721 566 -155
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…porter for consistency
Which problem is this PR solving?
The class name is inconsistent with other log exporter classes. I was working on a package, which needed to instantiate the exporters and had to add a workaround for this inconsistency. Then it became apparent that this is not per spec. #3764 (comment)
Fixes #4139
Short description of the changes
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
experimental/packages/exporter-logs-otlp-protoChecklist: